- Normalize login paths before applying request-body redaction. - Cover trailing-slash paths and assert the password never reaches logs.
63 lines
2.1 KiB
TypeScript
63 lines
2.1 KiB
TypeScript
import { CallHandler, ExecutionContext } from "@nestjs/common";
|
|
import { of } from "rxjs";
|
|
import { TraceLogger } from "../src/common/trace-logger";
|
|
import {
|
|
LoggingInterceptor,
|
|
redactAuthRequestBody,
|
|
} from "../src/interceptors/logging.interceptor";
|
|
|
|
describe("redactAuthRequestBody", () => {
|
|
it("redacts login passwords on local and API-prefixed route paths", () => {
|
|
const body = { username: "operator", password: "synthetic-secret" };
|
|
expect(redactAuthRequestBody("/auth/login", body)).toEqual({
|
|
username: "operator",
|
|
password: "[REDACTED]",
|
|
});
|
|
expect(redactAuthRequestBody("/api/v1/auth/login", body)).toEqual({
|
|
username: "operator",
|
|
password: "[REDACTED]",
|
|
});
|
|
expect(redactAuthRequestBody("/api/v1/auth/login/", body)).toEqual({
|
|
username: "operator",
|
|
password: "[REDACTED]",
|
|
});
|
|
expect(redactAuthRequestBody("/API/V1/AUTH/LOGIN/", body)).toEqual({
|
|
username: "operator",
|
|
password: "[REDACTED]",
|
|
});
|
|
expect(redactAuthRequestBody("/api/v1/scenarios", body)).toBe(body);
|
|
});
|
|
|
|
it("never logs a password received on the accepted trailing-slash login path", () => {
|
|
const loggedMessages: unknown[][] = [];
|
|
const debug = jest
|
|
.spyOn(TraceLogger.prototype, "debug")
|
|
.mockImplementation((...args: unknown[]) => {
|
|
loggedMessages.push(args);
|
|
});
|
|
const context = {
|
|
switchToHttp: () => ({
|
|
getRequest: () => ({
|
|
method: "POST",
|
|
url: "/api/v1/auth/login/",
|
|
path: "/api/v1/auth/login/",
|
|
body: { username: "operator", password: "synthetic-login-secret" },
|
|
}),
|
|
getResponse: () => ({ statusCode: 200 }),
|
|
}),
|
|
} as unknown as ExecutionContext;
|
|
const handler = {
|
|
handle: () => of({ user: { username: "operator" } }),
|
|
} as CallHandler;
|
|
|
|
try {
|
|
new LoggingInterceptor().intercept(context, handler).subscribe();
|
|
const output = JSON.stringify(loggedMessages);
|
|
expect(output).toContain("[REDACTED]");
|
|
expect(output).not.toContain("synthetic-login-secret");
|
|
} finally {
|
|
debug.mockRestore();
|
|
}
|
|
});
|
|
});
|