diff --git a/CHANGELOG.md b/CHANGELOG.md index 743fe1f..e0337cb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,18 @@ All notable changes to this project will be documented in this file. +## 1.21.1 - 2026-10-01 + +Changes since 1.21.0: + +### Changed + +- The credential page hides the credential data when it opens; a Reveal button shows it and Hide hides it again. The data is not rendered on the page until revealed. + +### Added + +- A `RevealableCodeBlock` UI component (a CodeBlock that starts hidden behind a Reveal/Hide button), with a Storybook story. + ## 1.21.0 - 2026-10-01 Changes since 1.20.2: diff --git a/client/.storybook/stories/RevealableCodeBlock.stories.tsx b/client/.storybook/stories/RevealableCodeBlock.stories.tsx new file mode 100644 index 0000000..01ff5e7 --- /dev/null +++ b/client/.storybook/stories/RevealableCodeBlock.stories.tsx @@ -0,0 +1,33 @@ +import type { Meta, StoryObj } from '@storybook/react-vite'; +import { expect, userEvent, within } from 'storybook/test'; +import { RevealableCodeBlock } from '../../src/ui/RevealableCodeBlock/RevealableCodeBlock'; + +const meta: Meta = { + title: 'UI/RevealableCodeBlock', + component: RevealableCodeBlock, + parameters: { layout: 'padded' }, + tags: ['autodocs'], +}; +export default meta; +type Story = StoryObj; + +export const Default: Story = { + args: { + language: 'json', + code: JSON.stringify({ username: 'admin', password: 's3cr3t-p4ss' }, null, 2), + }, + play: async ({ canvasElement }) => { + // The code is not rendered until revealed, and hidden again on the second click + const canvas = within(canvasElement); + const toggle = canvas.getByRole('button'); + await expect(canvasElement).not.toHaveTextContent('s3cr3t-p4ss'); + await expect(toggle).toHaveAttribute('aria-expanded', 'false'); + + await userEvent.click(toggle); + await expect(canvasElement.querySelector('code')).toHaveTextContent('s3cr3t-p4ss'); + await expect(toggle).toHaveAttribute('aria-expanded', 'true'); + + await userEvent.click(toggle); + await expect(canvasElement).not.toHaveTextContent('s3cr3t-p4ss'); + }, +}; diff --git a/client/src/i18n/locales/en.json b/client/src/i18n/locales/en.json index 89f8249..33a2d88 100644 --- a/client/src/i18n/locales/en.json +++ b/client/src/i18n/locales/en.json @@ -229,6 +229,11 @@ "light_mode": "Light mode", "dark_mode": "Dark mode" }, + "revealable": { + "hidden": "Hidden so secrets aren't exposed on screen.", + "reveal": "Reveal", + "hide": "Hide" + }, "pagination": { "prev": "Previous page", "next": "Next page", diff --git a/client/src/pages/credential/CredentialDetailPage.tsx b/client/src/pages/credential/CredentialDetailPage.tsx index 52e974c..be5866f 100644 --- a/client/src/pages/credential/CredentialDetailPage.tsx +++ b/client/src/pages/credential/CredentialDetailPage.tsx @@ -3,11 +3,18 @@ import { useNavigate, useParams } from 'react-router-dom'; import { useTranslation } from 'react-i18next'; import { usePageTitle } from '../../hooks/usePageTitle'; import { Upload, Pencil, Trash2, KeyRound } from 'lucide-react'; -import { CodeBlock } from '../../ui'; import { stringify as yamlStringify } from 'yaml'; import { credentials } from '../../api'; import type { Credential } from '../../api'; -import { Breadcrumbs, Button, Card, DescriptionList, Timestamp, UuidBadge } from '../../ui'; +import { + Breadcrumbs, + Button, + Card, + DescriptionList, + RevealableCodeBlock, + Timestamp, + UuidBadge, +} from '../../ui'; import { DeleteConfirmationModal } from '../../components/modals'; import styles from '../Page.module.css'; @@ -117,7 +124,8 @@ export function CredentialDetailPage() {

{t('credentials.section_data')}

- { try { diff --git a/client/src/ui/RevealableCodeBlock/RevealableCodeBlock.module.css b/client/src/ui/RevealableCodeBlock/RevealableCodeBlock.module.css new file mode 100644 index 0000000..5771754 --- /dev/null +++ b/client/src/ui/RevealableCodeBlock/RevealableCodeBlock.module.css @@ -0,0 +1,17 @@ +.wrapper { + display: flex; + align-items: flex-start; + gap: var(--space-3); +} + +.content { + flex: 1; + min-width: 0; +} + +.placeholder { + margin: 0; + color: var(--color-text-muted); + font-size: var(--font-size-sm); + line-height: 1.6; +} diff --git a/client/src/ui/RevealableCodeBlock/RevealableCodeBlock.tsx b/client/src/ui/RevealableCodeBlock/RevealableCodeBlock.tsx new file mode 100644 index 0000000..42e9c4a --- /dev/null +++ b/client/src/ui/RevealableCodeBlock/RevealableCodeBlock.tsx @@ -0,0 +1,38 @@ +import { useState } from 'react'; +import { useTranslation } from 'react-i18next'; +import { Eye, EyeOff } from 'lucide-react'; +import { Button } from '../Button/Button'; +import { CodeBlock } from '../CodeBlock/CodeBlock'; +import styles from './RevealableCodeBlock.module.css'; + +export interface RevealableCodeBlockProps { + code: string; + language?: string; +} + +/** A CodeBlock that starts hidden; the code is only rendered after the user reveals it. */ +export function RevealableCodeBlock({ code, language }: RevealableCodeBlockProps) { + const { t } = useTranslation(); + const [revealed, setRevealed] = useState(false); + + return ( +
+
+ {revealed ? ( + + ) : ( +

{t('revealable.hidden')}

+ )} +
+ +
+ ); +} diff --git a/client/src/ui/index.ts b/client/src/ui/index.ts index db0755b..b57f21d 100644 --- a/client/src/ui/index.ts +++ b/client/src/ui/index.ts @@ -43,6 +43,9 @@ export type { SearchProps } from './Search/Search'; export { CodeBlock } from './CodeBlock/CodeBlock'; export type { CodeBlockProps } from './CodeBlock/CodeBlock'; +export { RevealableCodeBlock } from './RevealableCodeBlock/RevealableCodeBlock'; +export type { RevealableCodeBlockProps } from './RevealableCodeBlock/RevealableCodeBlock'; + export { CodeEditor } from './CodeEditor/CodeEditor'; export type { CodeEditorProps } from './CodeEditor/CodeEditor'; diff --git a/package-lock.json b/package-lock.json index 9ead420..2751341 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "liqa", - "version": "1.21.0", + "version": "1.21.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "liqa", - "version": "1.21.0", + "version": "1.21.1", "workspaces": [ "server", "client" diff --git a/package.json b/package.json index 28685be..79be934 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "liqa", - "version": "1.21.0", + "version": "1.21.1", "private": true, "engines": { "node": ">=24"