feat(scenario): attach step output and assertion details to run log
- "Step N passed" log entry carries the step's return value as data
- context.assert accepts an optional details argument; on failure the
assertion:fail entry stores { details, error } as data
- assertion failures throw AssertionFailedError so "Step N failed" and
"Snippet X failed" entries name only the assertion, without repeating
the details; the step run description keeps the full message
- exported e2e runtime accepts and prints assert details
- log output shows elapsed time in whole seconds, matching the stored
timestamp resolution
- run artifact and scenario file names link to the inline file content
in a new tab
This commit is contained in:
9 files changed
+195
-17
No files matched your search
@@ -112,12 +112,12 @@ Every entry is tagged with where it came from: `step:<N>`, or `snippet:<alias>`
|
||||
|
||||
## Assertions
|
||||
|
||||
### `context.assert(fn, description)` → `Promise<void>`
|
||||
### `context.assert(fn, description, details?)` → `Promise<void>`
|
||||
|
||||
Runs `fn` (sync or async) and requires it to return exactly `true`.
|
||||
|
||||
- On success, it logs `description` (tagged `assertion:pass`).
|
||||
- If `fn` returns anything else or throws, it logs `Assertion failed: <description>` as an error (tagged `assertion:fail`) and throws, which fails the step.
|
||||
- If `fn` returns anything else or throws, it logs `Assertion failed: <description>` as an error (tagged `assertion:fail`) and throws, which fails the step. The entry's data holds `details` (if given) and the exception message as `error` (if `fn` threw).
|
||||
|
||||
Await it, or a failure will not stop the step.
|
||||
|
||||
@@ -128,6 +128,15 @@ await context.assert(
|
||||
);
|
||||
```
|
||||
|
||||
Pass large diagnostics (e.g. a response body) as `details` rather than in `description`, so the message stays short:
|
||||
|
||||
```js
|
||||
await context.assert(() => response.ok(), "Validation must pass", {
|
||||
status: response.status(),
|
||||
body: await response.json(),
|
||||
});
|
||||
```
|
||||
|
||||
Use `expect` instead for assertions that wait and retry until the page matches, e.g. `await expect(locator).toBeVisible()`.
|
||||
|
||||
## Snippets
|
||||
|
||||
@@ -554,7 +554,23 @@ function RunDetail() {
|
||||
rowKey={(f) => f.id}
|
||||
columns={
|
||||
[
|
||||
{ key: 'name', header: t('files.name'), render: (f) => f.name },
|
||||
{
|
||||
key: 'name',
|
||||
header: t('files.name'),
|
||||
// Served inline, so the browser shows what it can (images, text, PDF).
|
||||
render: (f) =>
|
||||
isFileExpired(f) ? (
|
||||
f.name
|
||||
) : (
|
||||
<a
|
||||
href={runFiles.contentUrl(id!, runId!, f.id)}
|
||||
target="_blank"
|
||||
rel="noopener noreferrer"
|
||||
>
|
||||
{f.name}
|
||||
</a>
|
||||
),
|
||||
},
|
||||
{
|
||||
key: 'mimeType',
|
||||
header: t('files.mimeType'),
|
||||
|
||||
@@ -761,7 +761,19 @@ export function ScenarioDetailPage() {
|
||||
{
|
||||
key: 'name',
|
||||
header: t('files.name'),
|
||||
render: (f) => f.name,
|
||||
// Served inline, so the browser shows what it can (images, text, PDF).
|
||||
render: (f) =>
|
||||
isFileExpired(f) ? (
|
||||
f.name
|
||||
) : (
|
||||
<a
|
||||
href={scenarioFiles.contentUrl(id!, f.id)}
|
||||
target="_blank"
|
||||
rel="noopener noreferrer"
|
||||
>
|
||||
{f.name}
|
||||
</a>
|
||||
),
|
||||
},
|
||||
{
|
||||
key: 'mimeType',
|
||||
|
||||
@@ -24,10 +24,13 @@ export interface LogOutputProps {
|
||||
className?: string;
|
||||
}
|
||||
|
||||
/** "+12.345s" (or "-" if before startTime, e.g. clock skew). */
|
||||
/**
|
||||
* "+12s" (or "-" if before startTime, e.g. clock skew). Log timestamps are
|
||||
* stored with second resolution, so fractions would be noise.
|
||||
*/
|
||||
function formatElapsed(deltaMs: number): string {
|
||||
const sign = deltaMs < 0 ? '-' : '+';
|
||||
return `${sign}${(Math.abs(deltaMs) / 1000).toFixed(3)}s`;
|
||||
return `${sign}${Math.round(Math.abs(deltaMs) / 1000)}s`;
|
||||
}
|
||||
|
||||
/** Pretty-prints `data` if it's valid JSON, otherwise returns it as-is. */
|
||||
|
||||
Reference in new issue
Block a user