chore(deps): update dependencies and bring storybook up to date
- update client and server dependencies within their ranges, keeping all playwright packages aligned at 1.63 - fix code flagged by react-hooks 7.1: refs written during render and synchronous setState in effects - add stories for the ui components that had none, with interaction tests, and cover all DescriptionList layouts - drop the unused mdx stories pattern - run the storybook tests as part of the pre-commit checks - bump version to 1.20.1
This commit is contained in:
1 parent
9f341719ef
commit
8aadbd25fb
20 files changed
+5048
-3616
No files matched your search
@@ -68,10 +68,12 @@ export function RunsPage() {
|
||||
const sortDirRef = useRef(sortDir);
|
||||
const pageRef = useRef(page);
|
||||
const pageSizeRef = useRef(pageSize);
|
||||
sortByRef.current = sortBy;
|
||||
sortDirRef.current = sortDir;
|
||||
pageRef.current = page;
|
||||
pageSizeRef.current = pageSize;
|
||||
useEffect(() => {
|
||||
sortByRef.current = sortBy;
|
||||
sortDirRef.current = sortDir;
|
||||
pageRef.current = page;
|
||||
pageSizeRef.current = pageSize;
|
||||
}, [sortBy, sortDir, page, pageSize]);
|
||||
|
||||
const load = useCallback(
|
||||
(orderBy: string, orderDir: SortDirection, p: number, limit: number) => {
|
||||
|
||||
@@ -98,7 +98,7 @@ export function ScenarioDetailPage() {
|
||||
|
||||
// Files state
|
||||
const [files, setFiles] = useState<FileMetadata[]>([]);
|
||||
const [filesLoading, setFilesLoading] = useState(false);
|
||||
const [filesLoading, setFilesLoading] = useState(true);
|
||||
const [uploadOpen, setUploadOpen] = useState(false);
|
||||
const [uploadFile, setUploadFile] = useState<File | null>(null);
|
||||
const [uploadExpiresAt, setUploadExpiresAt] = useState('');
|
||||
@@ -106,9 +106,10 @@ export function ScenarioDetailPage() {
|
||||
|
||||
const [usedSnippets, setUsedSnippets] = useState<UsedSnippet[]>([]);
|
||||
|
||||
const loadFiles = useCallback(async () => {
|
||||
// Fetches the files; `filesLoading` starts as true for the fetch from the
|
||||
// load effect, and `loadFiles` sets it for reloads (e.g. after an upload)
|
||||
const fetchFiles = useCallback(async () => {
|
||||
if (!id) return;
|
||||
setFilesLoading(true);
|
||||
try {
|
||||
const result = await scenarioFiles.list(id);
|
||||
setFiles(result.items);
|
||||
@@ -117,6 +118,11 @@ export function ScenarioDetailPage() {
|
||||
}
|
||||
}, [id]);
|
||||
|
||||
const loadFiles = async () => {
|
||||
setFilesLoading(true);
|
||||
await fetchFiles();
|
||||
};
|
||||
|
||||
useEffect(() => {
|
||||
if (!id) return;
|
||||
void scenarios
|
||||
@@ -126,7 +132,7 @@ export function ScenarioDetailPage() {
|
||||
setScenarioCreds(s.scenarioCredentials ?? []);
|
||||
})
|
||||
.finally(() => setLoading(false));
|
||||
void loadFiles();
|
||||
void fetchFiles();
|
||||
scenarios
|
||||
.usedSnippets(id)
|
||||
.then(setUsedSnippets)
|
||||
@@ -141,7 +147,7 @@ export function ScenarioDetailPage() {
|
||||
setEnvs(r.data);
|
||||
})
|
||||
.catch(() => {});
|
||||
}, [id, loadFiles]);
|
||||
}, [id, fetchFiles]);
|
||||
|
||||
const openRunModal = () => {
|
||||
// Preselect the scenario's default environment (or the first one) when the
|
||||
|
||||
@@ -68,9 +68,10 @@ export function ScenariosPage() {
|
||||
const [pageSize, setPageSize] = useState(10);
|
||||
const [total, setTotal] = useState(0);
|
||||
|
||||
const load = useCallback(
|
||||
// Fetches a page; `loading` starts as true for the initial fetch from the
|
||||
// effect, and `load` sets it for later ones (no setState inside the effect)
|
||||
const fetchPage = useCallback(
|
||||
(orderBy: string, orderDir: SortDirection, p: number, limit: number) => {
|
||||
setLoading(true);
|
||||
Promise.all([
|
||||
scenarios.list(p, limit, orderBy, orderDir === 'asc' ? 'ASC' : 'DESC'),
|
||||
environments.list(1, 200),
|
||||
@@ -88,9 +89,14 @@ export function ScenariosPage() {
|
||||
[toast],
|
||||
);
|
||||
|
||||
const load = (orderBy: string, orderDir: SortDirection, p: number, limit: number) => {
|
||||
setLoading(true);
|
||||
fetchPage(orderBy, orderDir, p, limit);
|
||||
};
|
||||
|
||||
useEffect(() => {
|
||||
load('updatedAt', 'desc', 1, 10);
|
||||
}, [load]);
|
||||
fetchPage('updatedAt', 'desc', 1, 10);
|
||||
}, [fetchPage]);
|
||||
|
||||
const handleSort = (key: string, dir: SortDirection) => {
|
||||
setSortBy(key);
|
||||
|
||||
@@ -23,7 +23,9 @@ export function SessionsPage() {
|
||||
usePageTitle(t('sessions.title'));
|
||||
const navigate = useNavigate();
|
||||
const [items, setItems] = useState<Session[]>([]);
|
||||
const [loading, setLoading] = useState(true);
|
||||
// Loading until the current query's result has arrived (derived, so the
|
||||
// loading effect doesn't have to set state synchronously)
|
||||
const [loadedQuery, setLoadedQuery] = useState<string | null>(null);
|
||||
const [deleteId, setDeleteId] = useState<string | null>(null);
|
||||
const [deleting, setDeleting] = useState(false);
|
||||
const [sortBy, setSortBy] = useState('id');
|
||||
@@ -32,15 +34,18 @@ export function SessionsPage() {
|
||||
const [pageSize, setPageSize] = useState(10);
|
||||
const [total, setTotal] = useState(0);
|
||||
|
||||
const query = `${sortBy}|${sortDir}|${page}|${pageSize}`;
|
||||
const loading = loadedQuery !== query;
|
||||
|
||||
const load = useCallback((orderBy: string, orderDir: SortDirection, p: number, limit: number) => {
|
||||
setLoading(true);
|
||||
const key = `${orderBy}|${orderDir}|${p}|${limit}`;
|
||||
sessions
|
||||
.list(p, limit, orderBy, orderDir === 'asc' ? 'ASC' : 'DESC')
|
||||
.then((res) => {
|
||||
setItems(res.data);
|
||||
setTotal(res.total);
|
||||
})
|
||||
.finally(() => setLoading(false));
|
||||
.finally(() => setLoadedQuery(key));
|
||||
}, []);
|
||||
|
||||
useEffect(() => {
|
||||
|
||||
Reference in new issue
Block a user