feat(scenario): tag run log entries with their context
- scenario_run_logs gains a context column (step:N, snippet:alias, assertion:pass/fail, run), tracked through a call stack in CodeExecutorService so nested runSnippet calls tag their own and inner log lines - automatic step started/passed/failed entries and the Playwright trace upload notice are tagged accordingly - run log export (CSV/Markdown) and the logs search match context as well as message - add a LogOutput UI component: a terminal-style log viewer with level color coding, elapsed-time-since-start timestamps and a context tag, replacing the generic Table on the run detail page - show the full log list instead of paginating it, capped to a scrollable block - fix migrations.spec.ts's revert test, which only undid the last migration instead of all of them
This commit is contained in:
15 files changed
+383
-70
No files matched your search
@@ -36,6 +36,10 @@ export class ScenarioRunLogEntity {
|
||||
@Column({ type: "text", default: "log" })
|
||||
level: LogLevel;
|
||||
|
||||
// Where the message was generated, e.g. "step:2", "snippet:login", "assertion:pass"
|
||||
@Column({ type: "text", nullable: true })
|
||||
context: string | null;
|
||||
|
||||
@Column({ type: "text" })
|
||||
message: string;
|
||||
|
||||
|
||||
@@ -143,7 +143,7 @@ export class ScenarioSchedulerService implements OnModuleInit {
|
||||
statuses: ["pending", "waiting"],
|
||||
})
|
||||
.execute();
|
||||
this.persistLog(runId, null, "error", reason);
|
||||
this.persistLog(runId, null, "error", reason, "run");
|
||||
}
|
||||
|
||||
private persistLog(
|
||||
@@ -151,18 +151,19 @@ export class ScenarioSchedulerService implements OnModuleInit {
|
||||
stepRunId: string | null,
|
||||
level: "log" | "warn" | "error",
|
||||
message: string,
|
||||
context: string | null = null,
|
||||
): void {
|
||||
const seq = (this.runLogSeq.get(runId) ?? 0) + 1;
|
||||
this.runLogSeq.set(runId, seq);
|
||||
void this.runLogRepo.save(
|
||||
this.runLogRepo.create({ runId, stepRunId, level, message, seq }),
|
||||
this.runLogRepo.create({ runId, stepRunId, level, message, context, seq }),
|
||||
);
|
||||
}
|
||||
|
||||
private stepLogger(stepRunId: string, runId: string): ScriptLogger {
|
||||
return (level, msg) => {
|
||||
return (level, msg, context) => {
|
||||
this.logger[level](`StepRun #${stepRunId} script: ${msg}`);
|
||||
this.persistLog(runId, stepRunId, level, msg);
|
||||
this.persistLog(runId, stepRunId, level, msg, context ?? null);
|
||||
};
|
||||
}
|
||||
|
||||
@@ -384,6 +385,7 @@ export class ScenarioSchedulerService implements OnModuleInit {
|
||||
stepRun.id,
|
||||
"log",
|
||||
`Step ${step.order} started${step.title ? `: ${step.title}` : ""}`,
|
||||
`step:${step.order}`,
|
||||
);
|
||||
|
||||
try {
|
||||
@@ -402,6 +404,7 @@ export class ScenarioSchedulerService implements OnModuleInit {
|
||||
.browser(context)
|
||||
.code(step.execCode)
|
||||
.log(this.stepLogger(stepRun.id, stepRun.runId))
|
||||
.logContext(`step:${step.order}`)
|
||||
.getStepOutput(getStepOutput)
|
||||
.credentials(creds)
|
||||
.environment(env)
|
||||
@@ -527,6 +530,7 @@ export class ScenarioSchedulerService implements OnModuleInit {
|
||||
null,
|
||||
"log",
|
||||
"Playwright trace uploaded to run files (open with `npx playwright show-trace trace.zip` or https://trace.playwright.dev)",
|
||||
"run",
|
||||
);
|
||||
} catch (err) {
|
||||
this.logger.warn(
|
||||
@@ -557,6 +561,7 @@ export class ScenarioSchedulerService implements OnModuleInit {
|
||||
stepRun.id,
|
||||
"log",
|
||||
`Step ${stepRun.order} passed`,
|
||||
`step:${stepRun.order}`,
|
||||
);
|
||||
|
||||
// Find the next waiting step in this run (next by order)
|
||||
@@ -599,6 +604,7 @@ export class ScenarioSchedulerService implements OnModuleInit {
|
||||
stepRun.id,
|
||||
"error",
|
||||
`Step ${stepRun.order} failed: ${description}`,
|
||||
`step:${stepRun.order}`,
|
||||
);
|
||||
|
||||
await this.dumpPageOnFailure(stepRun);
|
||||
@@ -666,6 +672,7 @@ export class ScenarioSchedulerService implements OnModuleInit {
|
||||
stepRun.id,
|
||||
"log",
|
||||
`Step ${stepRun.order} failed: page dump uploaded to run files`,
|
||||
`step:${stepRun.order}`,
|
||||
);
|
||||
}
|
||||
}
|
||||
@@ -578,7 +578,12 @@ export class ScenarioService implements OnModuleInit {
|
||||
`Run ${runId} not found in scenario ${scenarioId}`,
|
||||
);
|
||||
const logs = await this.runLogRepo.find({
|
||||
where: q?.trim() ? { runId, message: Like(`%${q.trim()}%`) } : { runId },
|
||||
where: q?.trim()
|
||||
? [
|
||||
{ runId, message: Like(`%${q.trim()}%`) },
|
||||
{ runId, context: Like(`%${q.trim()}%`) },
|
||||
]
|
||||
: { runId },
|
||||
order: { seq: "ASC", createdAt: "ASC" },
|
||||
});
|
||||
return Object.assign(run, { logs });
|
||||
@@ -606,9 +611,9 @@ export class ScenarioService implements OnModuleInit {
|
||||
const escapeCsv = (value: string): string =>
|
||||
/[",\n]/.test(value) ? `"${value.replace(/"/g, '""')}"` : value;
|
||||
const rows = [
|
||||
["Timestamp", "Level", "Message"].map(escapeCsv).join(","),
|
||||
["Timestamp", "Level", "Context", "Message"].map(escapeCsv).join(","),
|
||||
...logs.map((l) =>
|
||||
[l.createdAt.toISOString(), l.level, l.message]
|
||||
[l.createdAt.toISOString(), l.level, l.context ?? "", l.message]
|
||||
.map((v) => escapeCsv(String(v)))
|
||||
.join(","),
|
||||
),
|
||||
@@ -617,7 +622,8 @@ export class ScenarioService implements OnModuleInit {
|
||||
}
|
||||
|
||||
const sections = logs.map(
|
||||
(l) => `## [${l.level}] ${l.createdAt.toISOString()}\n\n${l.message}`,
|
||||
(l) =>
|
||||
`## [${l.level}]${l.context ? ` (${l.context})` : ""} ${l.createdAt.toISOString()}\n\n${l.message}`,
|
||||
);
|
||||
return [`# Run ${runId} logs`, ...sections].join("\n\n");
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user