refactor(scenario): remove step type and simplify scheduler to exec-only

- remove StepType, type column, and type field from step entity and DTOs
- remove executeLoginStep, executeSignStep, executeExecStep from scheduler
- inline exec logic directly in executeStepRun; all steps run execCode
- remove AuthService, EnvironmentService, runEnvironments from scheduler
- remove type selector from CreateStepPage and EditStepPage
- remove type badge column from ScenarioDetailPage
- fix useEffect dependency arrays in RunDetailPage (FINAL, id, runId, polling)
- fix duplicate /snippets proxy key in vite.config.ts
- remove unused escapeHtml export from hljs.ts

server/src/scenario/scenario-scheduler.service.ts

@@ -12,11 +12,8 @@ import { ScenarioRunStepEntity } from "./scenario-run-step.entity";
 import { ScenarioRunLogEntity } from "./scenario-run-log.entity";
 import { ScenarioStepEntity } from "./scenario-step.entity";
 import type { ScriptLogger } from "../code-executor/code-executor.service";
-import { AuthService } from "../auth/auth.service";
 import { CodeExecutorService } from "../code-executor/code-executor.service";
 import { ScenarioService } from "./scenario.service";
-import { EnvironmentService } from "../environment/environment.service";
-import type { EnvironmentUrls } from "../environment/environment.entity";
 import { SnippetService } from "../snippet/snippet.service";
 
 interface ValidateResult {
@@ -37,8 +34,6 @@ export class ScenarioSchedulerService {
   private readonly runBrowsers = new Map<string, BrowserHandle>();
   // Cache credential maps per run (built once when a run starts)
   private readonly runCredentials = new Map<string, Record<string, unknown>>();
-  // Cache environment URLs per run (resolved from the first login step)
-  private readonly runEnvironments = new Map<string, EnvironmentUrls>();
   // Cache snippet code map per run (built once when a run starts)
   private readonly runSnippets = new Map<string, Record<string, string>>();
 
@@ -49,10 +44,8 @@ export class ScenarioSchedulerService {
     private readonly runStepRepo: Repository<ScenarioRunStepEntity>,
     @InjectRepository(ScenarioRunLogEntity)
     private readonly runLogRepo: Repository<ScenarioRunLogEntity>,
-    private readonly authService: AuthService,
     private readonly codeExecutor: CodeExecutorService,
     private readonly scenarioService: ScenarioService,
-    private readonly environmentService: EnvironmentService,
     private readonly snippetService: SnippetService,
   ) {}
 
@@ -92,30 +85,6 @@ export class ScenarioSchedulerService {
     };
   }
 
-  /**
-   * Finds the first login step for a scenario and returns the environment URLs
-   * for the environment named in that step's execCode. Returns null if there is
-   * no login step or the environment cannot be found.
-   */
-  private async resolveRunEnvironment(
-    scenarioId: string,
-  ): Promise<EnvironmentUrls | null> {
-    try {
-      const scenario = await this.scenarioService.findOne(scenarioId);
-      const loginStep = scenario.steps.find((s) => s.type === "login");
-      if (!loginStep?.execCode) return null;
-      const params = JSON.parse(loginStep.execCode) as {
-        environmentName?: string;
-      };
-      if (!params.environmentName) return null;
-      const { data } = await this.environmentService.findAll({});
-      const env = data.find((e) => e.name === params.environmentName);
-      return env?.urls ?? null;
-    } catch {
-      return null;
-    }
-  }
-
   // ── Job: pick up pending runs and process each to completion ─────────────
 
   @Interval(1000)
@@ -130,15 +99,12 @@ export class ScenarioSchedulerService {
       // Pre-load credential map for the scenario
       const credMap = await this.scenarioService
         .buildCredentialMap(run.scenarioId)
-        .catch(() => ({} as Record<string, unknown>));
+        .catch(() => ({}) as Record<string, unknown>);
       this.runCredentials.set(run.id, credMap);
-      // Resolve environment from the first login step (best-effort)
-      const envUrls = await this.resolveRunEnvironment(run.scenarioId);
-      if (envUrls) this.runEnvironments.set(run.id, envUrls);
       // Pre-load snippet map
       const snippetMap = await this.snippetService
         .buildSnippetMap()
-        .catch(() => ({} as Record<string, string>));
+        .catch(() => ({}) as Record<string, string>);
       this.runSnippets.set(run.id, snippetMap);
       const traceId = crypto.randomUUID();
       void traceStorage.run({ traceId }, () =>
@@ -176,7 +142,6 @@ export class ScenarioSchedulerService {
     } finally {
       this.activeRuns.delete(runId);
       this.runCredentials.delete(runId);
-      this.runEnvironments.delete(runId);
       this.runSnippets.delete(runId);
     }
   }
@@ -191,13 +156,45 @@ export class ScenarioSchedulerService {
     );
 
     try {
-      if (step.type === "login") {
-        await this.executeLoginStep(stepRun, step);
-      } else if (step.type === "sign") {
-        await this.executeSignStep(stepRun, step);
-      } else {
-        await this.executeExecStep(stepRun, step);
+      if (!step.execCode) throw new Error("step has no execCode");
+      this.codeExecutor.validate(step.execCode);
+      const { page, context } = await this.getOrCreateBrowserHandle(
+        stepRun.runId,
+      );
+      const getStepOutput = this.makeGetStepOutput(stepRun);
+      const creds = this.runCredentials.get(stepRun.runId);
+      const snips = this.runSnippets.get(stepRun.runId);
+      const { result: execOutput } = await this.codeExecutor.execute(
+        page,
+        context,
+        step.execCode,
+        this.stepLogger(stepRun.id, stepRun.runId),
+        getStepOutput,
+        creds,
+        undefined,
+        snips,
+      );
+
+      if (step.validateCode) {
+        this.codeExecutor.validate(step.validateCode);
+        const { result } = await this.codeExecutor.execute(
+          page,
+          context,
+          step.validateCode,
+          this.stepLogger(stepRun.id, stepRun.runId),
+          getStepOutput,
+          creds,
+          undefined,
+          snips,
+          execOutput,
+        );
+        const vr = this.parseValidateResult(result);
+        if (!vr.success) throw new Error(vr.description ?? "Validation failed");
+        await this.passStepRun(stepRun, vr.description ?? null, execOutput);
+        return;
       }
+
+      await this.passStepRun(stepRun, null, execOutput);
     } catch (err) {
       const msg = (err as Error).message ?? String(err);
       this.logger.error(`StepRun #${stepRun.id} threw: ${msg}`);
@@ -207,7 +204,9 @@ export class ScenarioSchedulerService {
 
   // ── Shared browser per run ─────────────────────────────────────────────────
 
-  private async getOrCreateBrowserHandle(runId: string): Promise<BrowserHandle> {
+  private async getOrCreateBrowserHandle(
+    runId: string,
+  ): Promise<BrowserHandle> {
     const existing = this.runBrowsers.get(runId);
     if (existing) return existing;
 
@@ -238,154 +237,6 @@ export class ScenarioSchedulerService {
     }
   }
 
-  // ── Login step ─────────────────────────────────────────────────────────────
-
-  private async executeLoginStep(
-    stepRun: ScenarioRunStepEntity,
-    step: ScenarioStepEntity,
-  ): Promise<void> {
-    // execCode must be a JSON object: { "keyId": "...", "environmentName": "..." }
-    let params: { keyId: string; environmentName: string };
-    try {
-      params = JSON.parse(step.execCode ?? "{}");
-    } catch {
-      throw new Error(
-        "login step execCode must be valid JSON with keyId and environmentName",
-      );
-    }
-    if (!params.keyId || !params.environmentName) {
-      throw new Error(
-        "login step execCode must include keyId and environmentName",
-      );
-    }
-
-    const loginResult = await this.authService.login(
-      params.keyId,
-      params.environmentName,
-      step.sessionName ?? undefined,
-    );
-    this.logger.log(
-      `StepRun #${stepRun.id}: login OK, session=${loginResult.sessionName}`,
-    );
-
-    if (step.validateCode) {
-      const { page, context } = await this.getOrCreateBrowserHandle(
-        stepRun.runId,
-      );
-      this.codeExecutor.validate(step.validateCode);
-      const { result } = await this.codeExecutor.execute(
-        page,
-        context,
-        step.validateCode,
-        this.stepLogger(stepRun.id, stepRun.runId),
-        this.makeGetStepOutput(stepRun),
-        this.runCredentials.get(stepRun.runId),
-        this.runEnvironments.get(stepRun.runId),
-        this.runSnippets.get(stepRun.runId),
-        null,
-      );
-      const vr = this.parseValidateResult(result);
-      if (!vr.success) throw new Error(vr.description ?? "Validation failed");
-      await this.passStepRun(stepRun, vr.description ?? null);
-      return;
-    }
-
-    await this.passStepRun(stepRun, null);
-  }
-
-  // ── Exec step ──────────────────────────────────────────────────────────────
-
-  private async executeExecStep(
-    stepRun: ScenarioRunStepEntity,
-    step: ScenarioStepEntity,
-  ): Promise<void> {
-    if (!step.execCode) throw new Error("exec step has no execCode");
-
-    this.codeExecutor.validate(step.execCode);
-    const { page, context } = await this.getOrCreateBrowserHandle(
-      stepRun.runId,
-    );
-    const getStepOutput = this.makeGetStepOutput(stepRun);
-    const creds = this.runCredentials.get(stepRun.runId);
-    const env = this.runEnvironments.get(stepRun.runId);
-    const snips = this.runSnippets.get(stepRun.runId);
-    const { result: execOutput } = await this.codeExecutor.execute(
-      page,
-      context,
-      step.execCode,
-      this.stepLogger(stepRun.id, stepRun.runId),
-      getStepOutput,
-      creds,
-      env,
-      snips,
-    );
-    this.logger.log(`StepRun #${stepRun.id}: exec OK`);
-
-    if (step.validateCode) {
-      this.codeExecutor.validate(step.validateCode);
-      const { result } = await this.codeExecutor.execute(
-        page,
-        context,
-        step.validateCode,
-        this.stepLogger(stepRun.id, stepRun.runId),
-        getStepOutput,
-        creds,
-        env,
-        snips,
-        execOutput,
-      );
-      const vr = this.parseValidateResult(result);
-      if (!vr.success) throw new Error(vr.description ?? "Validation failed");
-      await this.passStepRun(stepRun, vr.description ?? null, execOutput);
-      return;
-    }
-
-    await this.passStepRun(stepRun, null, execOutput);
-  }
-
-  // ── Sign step ──────────────────────────────────────────────────────────────
-
-  private async executeSignStep(
-    stepRun: ScenarioRunStepEntity,
-    step: ScenarioStepEntity,
-  ): Promise<void> {
-    // execCode must be a JSON object: { "keyId": "..." }
-    let params: { keyId: string };
-    try {
-      params = JSON.parse(step.execCode ?? "{}");
-    } catch {
-      throw new Error("sign step execCode must be valid JSON with keyId");
-    }
-    if (!params.keyId) throw new Error("sign step execCode must include keyId");
-
-    const { page, context } = await this.getOrCreateBrowserHandle(
-      stepRun.runId,
-    );
-    await this.authService.signWithKey(params.keyId, page);
-    this.logger.log(`StepRun #${stepRun.id}: sign OK`);
-
-    if (step.validateCode) {
-      this.codeExecutor.validate(step.validateCode);
-      const { result } = await this.codeExecutor.execute(
-        page,
-        context,
-        step.validateCode,
-        this.stepLogger(stepRun.id, stepRun.runId),
-        this.makeGetStepOutput(stepRun),
-        this.runCredentials.get(stepRun.runId),
-        this.runEnvironments.get(stepRun.runId),
-        this.runSnippets.get(stepRun.runId),
-        null,
-      );
-      const vr = this.parseValidateResult(result);
-      if (!vr.success) throw new Error(vr.description ?? "Validation failed");
-      await this.passStepRun(stepRun, vr.description ?? null);
-      return;
-    }
-
-    await this.passStepRun(stepRun, null);
-  }
-
   // ── Validation helper ──────────────────────────────────────────────────────
 
   private parseValidateResult(raw: unknown): ValidateResult {