feat(scenarios): show last run status and timestamp on scenarios list
- extend findAll to join latest run per scenario via correlated subquery - return lastRunStatus and lastRunAt fields in GET /scenarios response - add Last Run column with badge and timestamp to ScenariosPage - add integration tests for null and populated lastRunStatus
This commit is contained in:
@@ -63,7 +63,7 @@ export class ScenarioService {
|
||||
|
||||
async findAll(
|
||||
query: PaginationQueryDto<ScenarioOrderBy>,
|
||||
): Promise<PaginatedResult<ScenarioEntity>> {
|
||||
): Promise<PaginatedResult<ScenarioEntity & { lastRunStatus: string | null; lastRunAt: string | null }>> {
|
||||
const page = query.page ?? 1;
|
||||
const limit = query.limit ?? 20;
|
||||
const orderBy = query.orderBy ?? "id";
|
||||
@@ -73,7 +73,39 @@ export class ScenarioService {
|
||||
skip: (page - 1) * limit,
|
||||
take: limit,
|
||||
});
|
||||
return { data, total, page, limit };
|
||||
|
||||
let lastRunByScenario = new Map<string, { status: string; createdAt: Date }>();
|
||||
if (data.length > 0) {
|
||||
const ids = data.map((s) => s.id);
|
||||
const latestRuns = await this.runRepo
|
||||
.createQueryBuilder("r")
|
||||
.select(["r.scenarioId", "r.status", "r.createdAt"])
|
||||
.where("r.scenarioId IN (:...ids)", { ids })
|
||||
.andWhere((qb) => {
|
||||
const sub = qb
|
||||
.subQuery()
|
||||
.select("MAX(r2.createdAt)")
|
||||
.from(ScenarioRunEntity, "r2")
|
||||
.where("r2.scenarioId = r.scenarioId")
|
||||
.getQuery();
|
||||
return `r.createdAt = (${sub})`;
|
||||
})
|
||||
.getMany();
|
||||
lastRunByScenario = new Map(
|
||||
latestRuns.map((r) => [r.scenarioId, { status: r.status, createdAt: r.createdAt }]),
|
||||
);
|
||||
}
|
||||
|
||||
return {
|
||||
data: data.map((s) => ({
|
||||
...s,
|
||||
lastRunStatus: lastRunByScenario.get(s.id)?.status ?? null,
|
||||
lastRunAt: lastRunByScenario.get(s.id)?.createdAt?.toISOString() ?? null,
|
||||
})),
|
||||
total,
|
||||
page,
|
||||
limit,
|
||||
};
|
||||
}
|
||||
|
||||
async findOne(id: string): Promise<ScenarioEntity> {
|
||||
|
||||
@@ -171,6 +171,35 @@ describe("ScenarioController", () => {
|
||||
.get("/scenarios?orderDir=SIDEWAYS")
|
||||
.expect(400);
|
||||
});
|
||||
|
||||
it("returns lastRunStatus and lastRunAt as null when scenario has no runs", async () => {
|
||||
await createScenario("no-runs-sc");
|
||||
const res = await request(app.getHttpServer())
|
||||
.get("/scenarios?orderBy=name&orderDir=ASC")
|
||||
.expect(200);
|
||||
const item = res.body.data.find(
|
||||
(s: { name: string }) => s.name === "no-runs-sc",
|
||||
);
|
||||
expect(item).toBeDefined();
|
||||
expect(item.lastRunStatus).toBeNull();
|
||||
expect(item.lastRunAt).toBeNull();
|
||||
});
|
||||
|
||||
it("returns lastRunStatus and lastRunAt reflecting the most recent run", async () => {
|
||||
const sc = await createScenario("last-run-status-sc");
|
||||
await createRun(sc.id);
|
||||
const res = await request(app.getHttpServer())
|
||||
.get("/scenarios?orderBy=name&orderDir=ASC")
|
||||
.expect(200);
|
||||
const item = res.body.data.find(
|
||||
(s: { name: string }) => s.name === "last-run-status-sc",
|
||||
);
|
||||
expect(item).toBeDefined();
|
||||
expect(["pending", "in_progress", "pass", "fail"]).toContain(
|
||||
item.lastRunStatus,
|
||||
);
|
||||
expect(typeof item.lastRunAt).toBe("string");
|
||||
});
|
||||
});
|
||||
|
||||
// ── GET /scenarios/:id ─────────────────────────────────────────────────────
|
||||
|
||||
Reference in New Issue
Block a user